Skip to content

feat: refetchMode replace for streamedQuery #9092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 1, 2025
Merged

feat: refetchMode replace for streamedQuery #9092

merged 3 commits into from
May 1, 2025

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented May 1, 2025

No description provided.

@github-actions github-actions bot added documentation Improvements or additions to documentation package: query-core labels May 1, 2025
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 1, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 0de0222.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 3m 31s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 45s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-01 09:00:10 UTC

TkDodo
TkDodo commented May 1, 2025
View reviewed changes
packages/query-core/src/streamedQuery.ts
context.client.setQueryData<Array<TQueryFnData>>(
context.queryKey,
(prev = []) => {
return prev.concat([chunk])
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

- return prev.concat(chunk)
+ return prev.concat([chunk])

this tiny change is hard to see, but it fixes an issue where TQueryFnData is in itself an array, which got flattened implicitly by concat

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a test for this, too: 0de0222

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 1, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9092

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9092

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9092

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9092

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9092

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9092

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9092

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9092

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9092

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9092

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9092

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9092

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9092

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9092

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9092

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9092

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9092

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9092

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9092

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9092

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9092

commit: 0de0222

@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2025 •
edited
Loading

Sizes for commit 0de0222:

Branch Bundle Size
Main
This PR

@codecov Codecov
Copy link

codecov bot commented May 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.05%. Comparing base (7d25373) to head (0de0222).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9092       +/-   ##
===========================================
+ Coverage   44.56%   59.05%   +14.49%     
===========================================
  Files         203      138       -65     
  Lines        8101     5361     -2740     
  Branches     1804     1420      -384     
===========================================
- Hits         3610     3166      -444     
+ Misses       4059     1906     -2153     
+ Partials      432      289      -143
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 85.23% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 95.96% <100.00%> (+0.01%) ⬆️
@tanstack/query-devtools 3.61% <ø> (ø)
@tanstack/query-persist-client-core 73.46% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.42% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.48% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 88.15% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.10% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TkDodo TkDodo merged commit ff0131b into main May 1, 2025
7 checks passed
@TkDodo TkDodo deleted the feature/refetchmode-replace branch May 1, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation package: query-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TkDodo