Skip to content

test(query-core): add test case for infiniteQueryBehavior #9101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 6, 2025

Conversation

minseong0324
Copy link
Contributor

I improved test coverage of infiniteQueryBehavior from 94.54% to 100%

Before

image

After

image

Copy link

nx-cloud bot commented May 3, 2025

View your CI Pipeline Execution ↗ for commit bbfd0be.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 58s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 45s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-06 19:48:58 UTC

Copy link

pkg-pr-new bot commented May 3, 2025

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9101

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9101

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9101

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9101

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9101

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9101

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9101

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9101

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9101

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9101

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9101

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9101

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9101

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9101

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9101

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9101

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9101

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9101

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9101

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9101

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9101

commit: bbfd0be

Copy link

codecov bot commented May 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.84%. Comparing base (6f8d57b) to head (bbfd0be).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9101       +/-   ##
===========================================
+ Coverage   44.50%   58.84%   +14.34%     
===========================================
  Files         204      139       -65     
  Lines        8150     5404     -2746     
  Branches     1821     1441      -380     
===========================================
- Hits         3627     3180      -447     
+ Misses       4080     1924     -2156     
+ Partials      443      300      -143     
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 85.04% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental 24.39% <ø> (ø)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 96.14% <ø> (+0.17%) ⬆️
@tanstack/query-devtools 3.61% <ø> (ø)
@tanstack/query-persist-client-core 73.46% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.42% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.48% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 88.15% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.10% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@manudeli manudeli self-requested a review May 5, 2025 05:13
@minseong0324 minseong0324 force-pushed the test/infinite-query-behavior branch from 9b90319 to bbfd0be Compare May 6, 2025 19:44
@minseong0324 minseong0324 requested a review from manudeli May 6, 2025 19:46
@manudeli
Copy link
Collaborator

manudeli commented May 6, 2025

@minseong0324 Thanks, Let's go to Coverage 100% 🚀

@manudeli manudeli merged commit 732089e into TanStack:main May 6, 2025
7 checks passed
xiaoyu2er pushed a commit to TanStack-dev/query that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants