-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
test(query-core): add test case for infiniteQueryBehavior #9101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
manudeli
merged 9 commits into
TanStack:main
from
minseong0324:test/infinite-query-behavior
May 6, 2025
Merged
test(query-core): add test case for infiniteQueryBehavior #9101
manudeli
merged 9 commits into
TanStack:main
from
minseong0324:test/infinite-query-behavior
May 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View your CI Pipeline Execution ↗ for commit bbfd0be.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9101 +/- ##
===========================================
+ Coverage 44.50% 58.84% +14.34%
===========================================
Files 204 139 -65
Lines 8150 5404 -2746
Branches 1821 1441 -380
===========================================
- Hits 3627 3180 -447
+ Misses 4080 1924 -2156
+ Partials 443 300 -143 🚀 New features to boost your workflow:
|
manudeli
reviewed
May 5, 2025
packages/query-core/src/__tests__/infiniteQueryBehavior.test.tsx
Outdated
Show resolved
Hide resolved
packages/query-core/src/__tests__/infiniteQueryBehavior.test.tsx
Outdated
Show resolved
Hide resolved
manudeli
reviewed
May 5, 2025
packages/query-core/src/__tests__/infiniteQueryBehavior.test.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Jonghyeon Ko <[email protected]>
9b90319
to
bbfd0be
Compare
manudeli
approved these changes
May 6, 2025
@minseong0324 Thanks, Let's go to Coverage 100% 🚀 |
xiaoyu2er
pushed a commit
to TanStack-dev/query
that referenced
this pull request
May 6, 2025
) Co-authored-by: Jonghyeon Ko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I improved test coverage of
infiniteQueryBehavior
from 94.54% to 100%Before
After