Skip to content

refactor(angular-query): use factory for IS_RESTORING injection token default value #9107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

refactor(angular-query): use factory for IS_RESTORING injection token default value #9107

merged 1 commit into from
May 5, 2025

Conversation

arnoud-dv
Copy link
Collaborator

@arnoud-dv arnoud-dv commented May 5, 2025 •
edited
Loading

This ensures IS_RESTORING always provides a valid signal.

Initializes the signal to true when using withPersistQueryClient.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 5, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 6157a43.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 4s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-05 18:43:09 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 5, 2025

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9107

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9107

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9107

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9107

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9107

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9107

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9107

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9107

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9107

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9107

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9107

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9107

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9107

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9107

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9107

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9107

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9107

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9107

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9107

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9107

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9107

commit: 6157a43

@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2025

Sizes for commit 6157a43:

Branch Bundle Size
Main
This PR

@codecov Codecov
Copy link

codecov bot commented May 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.93%. Comparing base (2121836) to head (6157a43).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9107       +/-   ##
===========================================
+ Coverage   44.50%   85.93%   +41.43%     
===========================================
  Files         204       17      -187     
  Lines        8148      320     -7828     
  Branches     1817       73     -1744     
===========================================
- Hits         3626      275     -3351     
+ Misses       4079       40     -4039     
+ Partials      443        5      -438
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 85.04% <85.71%> (-0.19%) ⬇️
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arnoud-dv arnoud-dv merged commit d82fb69 into main May 5, 2025
7 checks passed
@arnoud-dv arnoud-dv deleted the refactor/angular-query-is-restoring branch May 5, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: angular-query-experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arnoud-dv