Skip to content

test(react-router): reproducer starter for #2255 #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

SeanCassiere
Copy link
Member

Important

These reproductions need to be corrected to match the expected route tree and the content to be displayed on the screen.

Starting for the reproductions for #2255

Copy link

nx-cloud bot commented Sep 4, 2024

View your CI Pipeline Execution ↗ for commit 551e649.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ❌ Failed 4m 16s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 23s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-12 08:04:08 UTC

Copy link

pkg-pr-new bot commented Sep 4, 2024

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@2262

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@2262

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@2262

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@2262

@tanstack/create-start

npm i https://pkg.pr.new/@tanstack/create-start@2262

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@2262

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@2262

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@2262

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@2262

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@2262

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@2262

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@2262

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@2262

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@2262

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@2262

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@2262

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/@tanstack/server-functions-plugin@2262

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@2262

@tanstack/start-api-routes

npm i https://pkg.pr.new/@tanstack/start-api-routes@2262

@tanstack/start-client

npm i https://pkg.pr.new/@tanstack/start-client@2262

@tanstack/start-config

npm i https://pkg.pr.new/@tanstack/start-config@2262

@tanstack/start-plugin

npm i https://pkg.pr.new/@tanstack/start-plugin@2262

@tanstack/start-router-manifest

npm i https://pkg.pr.new/@tanstack/start-router-manifest@2262

@tanstack/start-server

npm i https://pkg.pr.new/@tanstack/start-server@2262

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/@tanstack/start-server-functions-client@2262

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/@tanstack/start-server-functions-fetcher@2262

@tanstack/start-server-functions-handler

npm i https://pkg.pr.new/@tanstack/start-server-functions-handler@2262

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/@tanstack/start-server-functions-server@2262

@tanstack/start-server-functions-ssr

npm i https://pkg.pr.new/@tanstack/start-server-functions-ssr@2262

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@2262

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@2262

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@2262

commit: 551e649

@SeanCassiere
Copy link
Member Author

Currently, we've identified 3 scenarios that need resolution.

  1. /about route with an async loader where this is thrown notFound()
<root.NotFoundComponent />
  1. /about route with a non-async loader where this is thrown notFound()
<root.Component>
  <@tanstack/react-router->DefaultGlobalNotFound />
</root.Component>
  1. /route-that-does-not-exist
<root.Component>
  <root.NotFoundComponent />
</root.Component>

2 definitely shouldn't be happening since it should be traversing up the route-tree to select the notFoundComponent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant