Skip to content

test: add basic typings test based off basic example #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ChristianMurphy
Copy link
Contributor

No description provided.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 10, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 834a19a:

Sandbox Source
youthful-leavitt-b8ngx Configuration

@ChristianMurphy ChristianMurphy force-pushed the test/add-basic-type-test branch from 94bd828 to 834a19a Compare October 10, 2019 04:06
@dbertella
Copy link

I was following the new type definitions and I came up with a bit more complex example let me know if you feel like it's worthy to include it in the repo right now is here https://github.com/dbertella/react-table-playground I used few plugins there, not super polished but it can be a starting point

@ChristianMurphy
Copy link
Contributor Author

This PR is the first in a series turning the examples into typescript test cases.
If your advanced repo is one of the examples convered to typescript, or covers cases not covered in the examples it could be a welcome addition. 👍

@dbertella
Copy link

Is not exactly one of the examples but I wanted to build a use case that I need in which I combine different plugins altogether. It covers

useFilters
useSortBy
useBlockLayout
useResizeColumns

Plus I added some custom components using styled components. What I was interested in was to understand how to use it with typescript, for instance to made it run I needed to cast column to have all the properties from the included plugins, do you think it's worthy to create a issue with this and possibly discuss in there not to pollute this pr?

@ChristianMurphy
Copy link
Contributor Author

@dbertella sounds good, feel free to open a PR.

@ChristianMurphy ChristianMurphy deleted the test/add-basic-type-test branch November 2, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants