Skip to content

feat: Added Solution of Partition Problem #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Nov 14, 2021
Merged

feat: Added Solution of Partition Problem #1842

merged 18 commits into from
Nov 14, 2021

Conversation

Lazeeez
Copy link
Contributor

@Lazeeez Lazeeez commented Nov 9, 2021 •
edited by gitpod-io bot
Loading

Description of Change

Partition problem is to determine whether a given set can be partitioned into two subsets such that the sum of elements in both subsets is the same.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes: This implementation has dynamic programming in it with the time complexity of O(sum*n) and space complexity of O(sum*n) where sum is the sum of all the elements of vector

@Lazeeez Lazeeez changed the title feat: Added partition_problem.cpp feat: Added Solution of Partition Problem. Nov 9, 2021
@Panquesito7 Panquesito7 added the enhancement New feature or request label Nov 9, 2021
Panquesito7
Panquesito7 requested changes Nov 9, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! 🚀

@Panquesito7 Panquesito7 added the requested changes changes have been requested label Nov 9, 2021
Panquesito7
Panquesito7 requested changes Nov 9, 2021
View reviewed changes
@Panquesito7 Panquesito7 changed the title feat: Added Solution of Partition Problem. feat: Added Solution of Partition Problem Nov 10, 2021
@Lazeeez Lazeeez requested a review from Panquesito7 November 10, 2021 11:34
Panquesito7
Panquesito7 approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! 🚀 Thanks so much for your contribution! 😄👍

@Panquesito7 Panquesito7 added approved Approved; waiting for merge and removed requested changes changes have been requested labels Nov 10, 2021
@Panquesito7
Copy link
Member

Will merge for now. If any of you (@Amino19, @ayaankhan98, @mishraabhinn, or anyone else) have any objections, please comment here and make a separate PR to fix that. Thank you. 🙂

@Panquesito7 Panquesito7 merged commit 5147306 into TheAlgorithms:master Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@aminoxix aminoxix Awaiting requested review from aminoxix

@ayaankhan98 ayaankhan98 Awaiting requested review from ayaankhan98

@mishraabhinn mishraabhinn Awaiting requested review from mishraabhinn

Assignees
No one assigned
Labels
approved Approved; waiting for merge enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lazeeez @Panquesito7