-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Awesome CI Workflow Code formater: "2 files are not in one and only one directory" but they are in separate branches. #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@ayaankhan98, @mishraabhinn, thoughts? |
the failing check code is there: nodir_files = [file for file in cpp_files if file.count(os.sep) != 1 and "project_euler" not in file and "data_structure" not in file]
if nodir_files:
print(f"{len(nodir_files)} files are not in one and only one directory:")
print("\n".join(nodir_files) + "\n") |
…nly one directory
I found that Awesome workflow was counting the length of the modified file list in the number of undesired files. I proposed a solution in PR #900. |
In former version of .github/workflows/awesome_workflow.yml commits were permitted to present multiple solutions at one time. PR #901 reuse that piece of code. So to give alternative solution to this issue. |
…tory) (#900) * perf: faster implementation of the TwoSum problem * doc: fixed typos on comments * updating DIRECTORY.md * fix: comments on includes. Doxygen file. static test function * fix: #898 awesome-workflow: 1 files are not in one and only one directory * fix: revert 1.c changes Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
* perf: faster implementation of the TwoSum problem * doc: fixed typos on comments * updating DIRECTORY.md * fix: comments on includes. Doxygen file. static test function * fix: #898 revert the nodir_files check version prior 2c86fbb * fix: revert 1.c changes * Apply suggestions from code review Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com> Co-authored-by: David Leal <[email protected]>
Hey @Panquesito7 @kvedala,
On my fork's Github Actions I got this error from Awesome CI Workflow Code formatter; even if I separated the two files into two different commits.
Any idea how I could fix it?
Thanx
Originally posted by @straight-into-the-wall in #897 (comment)
The text was updated successfully, but these errors were encountered: