Skip to content

Close Scanner to avoid resource leak #5077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 12, 2024
Merged

Close Scanner to avoid resource leak #5077

merged 3 commits into from
Mar 12, 2024

Conversation

sozelfist
Copy link
Contributor

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@sozelfist sozelfist mentioned this pull request Mar 12, 2024
Closed
vil02
vil02 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These main methods should be simply removed and proper tests should be added. Thanks for fixing that.

@vil02 vil02 changed the title fix[bug]: resource leak: sc is never closed Close Scanner to avoid resource leak Mar 12, 2024
@vil02 vil02 merged commit ab37184 into TheAlgorithms:master Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vil02 vil02 vil02 approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sozelfist @vil02