Skip to content

Conversation

@black-tmin-oil
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy
Copy link

Hey @Kim-R2O,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: f840e210-bd70-11ea-ab91-9125a069a76b

Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool submission!, Lines 18-23 are the core of your algorithm so let’s put those lines into a function:

def horoscope(zodiac_sign: int, day: str = "today") -> str:
    url = ('https://www.horoscope.com/us/horoscopes/general/'
           f'horoscope-general-daily-{day}.aspx?sign={zodiac_sign}')
    soup = BeautifulSoup(requests.get(url).content, 'html.parser')
    return soup.find('div', class_= 'main-horoscope').p.text

Then move all the input() and print() code into __main__. This would allow someone else to easily put your algorithm into a bigger project. print(horoscope(8))

import requests

def horoscope():
print('Your daily Horoscope. \n')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to CONTRIBUTING.md algorithm functions should not print()

code refactoring, script editing
@cclauss cclauss merged commit 423dd2b into TheAlgorithms:master Jul 10, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* added daily horoscope scrapper

* Update daily horoscope scrapper script

code refactoring, script editing

* Update web_programming/daily_horoscope.py

Co-authored-by: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants