Implement the melkman anlgorithm for computing convex hulls #2916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
poyea
reviewed
Oct 8, 2020
poyea
added
the
hacktoberfest-accepted
Travis tests have failedHey @SimonLammer, TravisBuddy Request Identifier: e8ee7930-0992-11eb-b9d6-41d4da7e5060 |
SimonLammer
force-pushed
the
convex_hull-melkman
branch
from
c9371a0 to
bc2efde
Compare
Travis tests have failedHey @SimonLammer, TravisBuddy Request Identifier: 664c6120-0999-11eb-b9d6-41d4da7e5060 |
SimonLammer
force-pushed
the
convex_hull-melkman
branch
from
bc2efde to
7162412
Compare
Travis tests have failedHey @SimonLammer, TravisBuddy Request Identifier: d36267a0-0999-11eb-b9d6-41d4da7e5060 |
SimonLammer
force-pushed
the
convex_hull-melkman
branch
from
7162412 to
db5b1fa
Compare
Contributor
Author
|
@poyea Is there anything else I should to revise? |
Contributor
Author
|
@poyea ? |
kbakdev
approved these changes
Oct 22, 2020
poyea
approved these changes
Oct 29, 2020
Member
poyea
left a comment
poyea
left a comment
There was a problem hiding this comment.
Thank you for your pull request!🤩
Member
|
@SimonLammer Add a |
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
…ithms#2916) * Implement the melkman anlgorithm for computing convex hulls * Link melkman algorithm description * Format melkman algorithm code * Add type hints to functions * Fix build errors
peRFectBeliever
pushed a commit
to peRFectBeliever/Python
that referenced
this pull request
Apr 1, 2021
…ithms#2916) * Implement the melkman anlgorithm for computing convex hulls * Link melkman algorithm description * Format melkman algorithm code * Add type hints to functions * Fix build errors
Panquesito7
pushed a commit
to Panquesito7/Python
that referenced
this pull request
May 13, 2021
…ithms#2916) * Implement the melkman anlgorithm for computing convex hulls * Link melkman algorithm description * Format melkman algorithm code * Add type hints to functions * Fix build errors
shermanhui
pushed a commit
to shermanhui/Python
that referenced
this pull request
Oct 22, 2021
…ithms#2916) * Implement the melkman anlgorithm for computing convex hulls * Link melkman algorithm description * Format melkman algorithm code * Add type hints to functions * Fix build errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.Since the file didn't contain type hints at all, I didn't add them for this algorithm.Is this file the correct place for the algorithm? It is not a divide and conquer algorithm, but it is a convex_hull algorithm.