Skip to content

Hacktoberfest: Add project euler problem 51 #3018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhruvmanila merged 2 commits into from
Oct 12, 2020
Merged

Hacktoberfest: Add project euler problem 51 #3018

dhruvmanila merged 2 commits into from
Oct 12, 2020

Conversation

@Hyftar
Copy link
Contributor

@Hyftar Hyftar commented Oct 8, 2020

Describe your change:

This pull request adds the Project Euler problem 51

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Hyftar Hyftar force-pushed the project-euler-problem-51 branch from 0641338 to 0abd5db Compare October 8, 2020 01:49
NSachida
NSachida approved these changes Oct 8, 2020
View reviewed changes
Copy link

@NSachida NSachida left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First prime in the eight prime family is 121313

@Hyftar
Copy link
Contributor Author

Hyftar commented Oct 8, 2020

By replacing the first degit of 51 which is (5)
*3 =15
Joined with the last degit 1
That's 151

I don't understand what you're trying to explain

NSachida
NSachida approved these changes Oct 8, 2020
View reviewed changes
Copy link

@NSachida NSachida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can find the compete source code Here

@Hyftar
Copy link
Contributor Author

Hyftar commented Oct 8, 2020

You can find the compete source code Here

I don't understand what you're trying to explain, my code achieved the same result.

@Hyftar Hyftar mentioned this pull request Oct 8, 2020
Closed
@Hyftar
Copy link
Contributor Author

Hyftar commented Oct 11, 2020

This PR helping the issue #2695

dhruvmanila
dhruvmanila requested changes Oct 12, 2020
View reviewed changes
@dhruvmanila dhruvmanila added awaiting changes A maintainer has requested changes to this PR hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 12, 2020
@dhruvmanila dhruvmanila reopened this Oct 12, 2020
@Hyftar Hyftar requested a review from Kush1101 as a code owner October 12, 2020 16:52
@Hyftar Hyftar requested a review from dhruvmanila October 12, 2020 16:53
@Hyftar Hyftar force-pushed the project-euler-problem-51 branch from 4727024 to a0bf56a Compare October 12, 2020 16:54
dhruvmanila
dhruvmanila approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thank you for your contribution!

@dhruvmanila dhruvmanila merged commit 50d7ed8 into TheAlgorithms:master Oct 12, 2020
@dhruvmanila dhruvmanila removed the awaiting changes A maintainer has requested changes to this PR label Oct 12, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@Hyftar @stokhos
Add project euler problem 51 (TheAlgorithms#3018)
634842e 
* Add project euler problem 51

* Apply review suggestions
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@Hyftar
Add project euler problem 51 (TheAlgorithms#3018)
94c8ffc 
* Add project euler problem 51

* Apply review suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

+1 more reviewer

@NSachida NSachida NSachida approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Hyftar @dhruvmanila @NSachida