Skip to content

Conversation

@PTK12
Copy link
Contributor

@PTK12 PTK12 commented Oct 11, 2020

Describe your change:

Added rail fence cipher

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@PTK12 PTK12 requested a review from cclauss as a code owner October 11, 2020 10:59
@cclauss
Copy link
Member

cclauss commented Oct 11, 2020

#2510 (comment)

@AnupKumarPanwar AnupKumarPanwar merged commit 3859c65 into TheAlgorithms:master Oct 12, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Added rail fence cipher

* Update rail_fence_cipher.py

* Update rail_fence_cipher.py
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* Added rail fence cipher

* Update rail_fence_cipher.py

* Update rail_fence_cipher.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants