Skip to content

Add first solution for Project Euler Problem 207 #3522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhruvmanila merged 16 commits into from
Oct 29, 2020
Merged

Add first solution for Project Euler Problem 207 #3522

dhruvmanila merged 16 commits into from
Oct 29, 2020

Conversation

@PetitNigaud
Copy link
Contributor

@PetitNigaud PetitNigaud commented Oct 18, 2020

Describe your change:

I added the solution for the Project Euler problem 207 (#2695).

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

dhruvmanila
dhruvmanila requested changes Oct 19, 2020
View reviewed changes
@dhruvmanila dhruvmanila added the awaiting changes A maintainer has requested changes to this PR label Oct 19, 2020
dhruvmanila
dhruvmanila approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@dhruvmanila dhruvmanila merged commit 99adac0 into TheAlgorithms:master Oct 29, 2020
@PetitNigaud
Copy link
Contributor Author

PetitNigaud commented Oct 29, 2020 •
edited
Loading

If it's not too much of a bother, can you please add the hacktoberfest label?
Thanks anyway. I learned a lot about git and also Python, so I'm just glad having particitated.

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@PetitNigaud @stokhos
Add first solution for Project Euler Problem 207 (TheAlgorithms#3522)
ab40e19 
* add solution to Project Euler problem 206

* Add solution to Project Euler problem 205

* updating DIRECTORY.md

* updating DIRECTORY.md

* Revert "Add solution to Project Euler problem 205"

This reverts commit 64e3d36.

* Revert "add solution to Project Euler problem 206"

This reverts commit 53568cf.

* add solution for project euler problem 207

* updating DIRECTORY.md

* add type hint for output of helper function

* Correct default parameter value in solution

* use descriptive variable names and remove problem solution from doctest Fixes: TheAlgorithms#2695

Co-authored-by: nico <[email protected]>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@PetitNigaud @peRFectBeliever
Add first solution for Project Euler Problem 207 (TheAlgorithms#3522)
c800670 
* add solution to Project Euler problem 206

* Add solution to Project Euler problem 205

* updating DIRECTORY.md

* updating DIRECTORY.md

* Revert "Add solution to Project Euler problem 205"

This reverts commit 64e3d36.

* Revert "add solution to Project Euler problem 206"

This reverts commit 53568cf.

* add solution for project euler problem 207

* updating DIRECTORY.md

* add type hint for output of helper function

* Correct default parameter value in solution

* use descriptive variable names and remove problem solution from doctest Fixes: TheAlgorithms#2695

Co-authored-by: nico <[email protected]>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@PetitNigaud
Add first solution for Project Euler Problem 207 (TheAlgorithms#3522)
0d29889 
* add solution to Project Euler problem 206

* Add solution to Project Euler problem 205

* updating DIRECTORY.md

* updating DIRECTORY.md

* Revert "Add solution to Project Euler problem 205"

This reverts commit 64e3d36.

* Revert "add solution to Project Euler problem 206"

This reverts commit 53568cf.

* add solution for project euler problem 207

* updating DIRECTORY.md

* add type hint for output of helper function

* Correct default parameter value in solution

* use descriptive variable names and remove problem solution from doctest Fixes: TheAlgorithms#2695

Co-authored-by: nico <[email protected]>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@PetitNigaud @shermanhui
Add first solution for Project Euler Problem 207 (TheAlgorithms#3522)
1679290 
* add solution to Project Euler problem 206

* Add solution to Project Euler problem 205

* updating DIRECTORY.md

* updating DIRECTORY.md

* Revert "Add solution to Project Euler problem 205"

This reverts commit 64e3d36.

* Revert "add solution to Project Euler problem 206"

This reverts commit 53568cf.

* add solution for project euler problem 207

* updating DIRECTORY.md

* add type hint for output of helper function

* Correct default parameter value in solution

* use descriptive variable names and remove problem solution from doctest Fixes: TheAlgorithms#2695

Co-authored-by: nico <[email protected]>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

No one assigned

Labels

awaiting changes A maintainer has requested changes to this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PetitNigaud @dhruvmanila