Skip to content

Update lucas_series.py to include another method #3620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kush1101 merged 6 commits into from
Oct 26, 2020
Merged

Update lucas_series.py to include another method #3620

Kush1101 merged 6 commits into from
Oct 26, 2020

Conversation

@Kush1101
Copy link
Member

@Kush1101 Kush1101 commented Oct 21, 2020

Added another method to calculate lucas_numbers

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Kush1101
Update lucas_series.py
3bd6b8e 
Added another method to calculate lucas_numbers
@Kush1101
Fix pre-commit error
54d55ab
@Kush1101 Kush1101 requested a review from cclauss October 21, 2020 12:14
cclauss
cclauss reviewed Oct 24, 2020
View reviewed changes
cclauss
cclauss reviewed Oct 24, 2020
View reviewed changes
cclauss
cclauss reviewed Oct 24, 2020
View reviewed changes
@Kush1101 Kush1101 requested review from cclauss and poyea October 24, 2020 17:57
@Kush1101
Copy link
Member Author

Kush1101 commented Oct 25, 2020

@cclauss, should we merge it?

realDuYuanChao
realDuYuanChao reviewed Oct 26, 2020
View reviewed changes
@Kush1101 Kush1101 merged commit b93a9d8 into TheAlgorithms:master Oct 26, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@Kush1101 @stokhos
Update lucas_series.py to include another method (TheAlgorithms#3620)
ac8faac 
* Update lucas_series.py

Added another method to calculate lucas_numbers

* Fix pre-commit error

* Update lucas_series.py

* Update lucas_series.py

* Update lucas_series.py

* Update lucas_series.py
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@Kush1101 @peRFectBeliever
Update lucas_series.py to include another method (TheAlgorithms#3620)
20b7f3d 
* Update lucas_series.py

Added another method to calculate lucas_numbers

* Fix pre-commit error

* Update lucas_series.py

* Update lucas_series.py

* Update lucas_series.py

* Update lucas_series.py
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@Kush1101
Update lucas_series.py to include another method (TheAlgorithms#3620)
fbf13c8 
* Update lucas_series.py

Added another method to calculate lucas_numbers

* Fix pre-commit error

* Update lucas_series.py

* Update lucas_series.py

* Update lucas_series.py

* Update lucas_series.py
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@Kush1101 @shermanhui
Update lucas_series.py to include another method (TheAlgorithms#3620)
f347c2c 
* Update lucas_series.py

Added another method to calculate lucas_numbers

* Fix pre-commit error

* Update lucas_series.py

* Update lucas_series.py

* Update lucas_series.py

* Update lucas_series.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@realDuYuanChao realDuYuanChao realDuYuanChao left review comments

@poyea poyea poyea approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

@cclauss cclauss Awaiting requested review from cclauss

+1 more reviewer

@kbakdev kbakdev kbakdev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Kush1101 @cclauss @poyea @realDuYuanChao @kbakdev