Skip to content

Conversation

@taseikyo
Copy link
Contributor

  • update naming style to snake_case
  • add type hints

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

- update naming style to snake_case
- add type hints
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@poyea poyea merged commit 4fa8c9d into TheAlgorithms:master Oct 29, 2020
@taseikyo taseikyo deleted the patch branch October 29, 2020 01:26
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
- update naming style to snake_case
- add type hints
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
- update naming style to snake_case
- add type hints
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
- update naming style to snake_case
- add type hints
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
- update naming style to snake_case
- add type hints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants