Skip to content

Conversation

@MaximSmolskiy
Copy link
Member

@MaximSmolskiy MaximSmolskiy commented Jul 24, 2022

Describe your change:

Improve Project Euler problem 030 solution 1 - the top 8 slowest solution on GitHub Actions logs (under slowest 10 durations: 3.90s call scripts/validate_solutions.py::test_project_euler[problem_030/sol1.py]):

  • Fix comments

  • Improve solution (locally 3+ times - from 3+ seconds to ~1 second)

  • Add an algorithm?

  • Fix a bug or typo in an existing algorithm?

  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Jul 24, 2022
@ghost ghost removed the tests are failing Do not merge until tests pass label Jul 24, 2022
@dhruvmanila dhruvmanila self-assigned this Jul 25, 2022
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jul 25, 2022
@dhruvmanila dhruvmanila merged commit 9095921 into TheAlgorithms:master Jul 25, 2022
@MaximSmolskiy MaximSmolskiy deleted the improve-project-euler-problem-030-solution-1 branch July 25, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants