Skip to content

Conversation

@wissamfawaz
Copy link
Contributor

@wissamfawaz wissamfawaz commented Oct 16, 2022

Describe your change:

Added a Pascal triangle implementation in the "other" folder. Note that I incorporated the changes that were requested by the reviewer to my previous PR.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 16, 2022
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make a seperate pull request for your CONTRIBUTING.md changes. Only create an algorithm in your pull request

@wissamfawaz
Copy link
Contributor Author

Please make a seperate pull request for your CONTRIBUTING.md changes. Only create an algorithm in your pull request

Kindly note that I reversed the changes to "CONTRIBUTING.md".

@wissamfawaz wissamfawaz requested review from CaedenPH and ZeroDayOwl and removed request for CaedenPH and ZeroDayOwl October 16, 2022 16:54
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 30, 2022
@cclauss cclauss merged commit d1430aa into TheAlgorithms:master Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants