05-descendant-combinator: Add full solution #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatblindgeye
added
the
Status: Needs Review
thatblindgeye
requested changes
Mar 24, 2022
Comment on lines
6
to
14
|
|
||
| /* Other possible combinations of selectors | ||
|
|
||
| div p | ||
| div .text | ||
| .container p | ||
|
|
||
| */ |
There was a problem hiding this comment.
Couple of things:
- Suggestion: changing line 8 to "Below are some other possible descendant combinators:"
- The file just needs an empty new line at the end of it
There was a problem hiding this comment.
My mind was stuck in the "imperative mood" due to git commits. Haha
thatblindgeye
added
Status: Awaiting Changes
|
Added an empty new line at the end, but it doesn't show on github (Line 15). Please let me know if you see the changes on your end. |
thatblindgeye
approved these changes
Mar 26, 2022
|
Ah that's fine. I don't see the symbol warning about the lack of a new line in your latest changes so it's most likely good. Thank you for making this update! |
Oussama5379
added a commit
to Oussama5379/css-exercises
that referenced
this pull request
Feb 1, 2025
05-descendant-combinator: Add full solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete the following REQUIRED checkboxes:
location of change: brief description of changeformat, e.g.01-flex-center: Update self check1. Because:
Closes #153
2. This PR: