Skip to content

Flex and Foundations: add alt text for accessibility (#201) #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Flex and Foundations: add alt text for accessibility (#201) #202

merged 1 commit into from
Jul 25, 2022

Conversation

Amandasilvbr
Copy link
Contributor

Complete the following REQUIRED checkboxes:

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. 01-flex-center: Update self check

Complete the following checkbox ONLY IF it is applicable to your PR. You can complete it later if it is not currently applicable:

  • [] I have ensured that the TOP solution files match the Desired Outcome image

1. Because:

-Four html files were missing the alt attribute in the img tag. This compromises accessibility. In addition, the use of alternative texts is considered a good practice and should be encouraged whenever appropriate.
Closes #201

2. This PR:

-Four images were missing the "alt" attribute, so I added the alt texts to each of them.

If anyone has any suggestions, let's talk!

@dm-murphy dm-murphy self-requested a review July 25, 2022 21:38
@dm-murphy dm-murphy added Type: Accessibility Involves an accessibility feature or requires accessibility review Status: Under Review This issue/PR is being reviewed by at least one maintainer labels Jul 25, 2022
Copy link
Member

@dm-murphy dm-murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Amandasilvbr!

Great work and initiative in finding these and making the PR. Appreciate the help! 🙂

@dm-murphy dm-murphy merged commit 35adbf6 into TheOdinProject:main Jul 25, 2022
@Amandasilvbr
Copy link
Contributor Author

You are welcome!

@YoRobotCop
Copy link

Gracias por el soporte

@YoRobotCop
Copy link

Domain onion.onion

Oussama5379 added a commit to Oussama5379/css-exercises that referenced this pull request Feb 1, 2025
Flex and Foundations: add alt text for accessibility (TheOdinProject#201)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Under Review This issue/PR is being reviewed by at least one maintainer Type: Accessibility Involves an accessibility feature or requires accessibility review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flex and Foundations: add alt text for accessibility.
3 participants