Skip to content

04-chaining-selectors: Updated index.html and README.md #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jasonguf
Copy link
Contributor

Because

This pull request contains the updated index.html file with the src attributes for the images already pre-populated so that the user doesn't have to fill them out. A new folder called "images" is also added which contains the required images for this exercise. Lastly, the README.md file is updated and it no longer contains the note telling the user to download the images and to add them to the "images" folder.

This PR

  • Updated the index.html file with the src attributes for the images
  • Added the required images for the exercise into a new folder called "images"
  • Updated the README.md file by removing the note about downloading the images and placing them into the "images" folder

Issue

Closes #448

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. 01-flex-center: Update self check
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If applicable, I have ensured that the TOP solution files match the Desired Outcome image

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future @jasonguf please wait to be assigned an issue before submitting a PR. Another user had asked to be assigned first and the issue would have gone to them, and it also helps prevent multiple users submitting a PR for the same issue without realizing.

@thatblindgeye thatblindgeye merged commit 20d36ee into TheOdinProject:main Feb 11, 2024
AngryBabushka pushed a commit to AngryBabushka/css-exercises that referenced this pull request Feb 23, 2024
…ex_page

04-chaining-selectors: Updated index.html and README.md
TeamPlatinum1 pushed a commit to TeamPlatinum1/css-exercises that referenced this pull request Sep 3, 2024
…ex_page

04-chaining-selectors: Updated index.html and README.md
Oussama5379 added a commit to Oussama5379/css-exercises that referenced this pull request Feb 1, 2025
…ex_page

04-chaining-selectors: Updated index.html and README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - 04-chaining-selectors : images don't exist in the index page
2 participants