Skip to content

02-margin-and-padding-2: Updated solution.css and desired-outcome.png to solve Issue#545 #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

akash-shaw
Copy link
Contributor

Because

To solve issue Block and Inline: <Element defaults not really being mentioned so far in the course> #545

This PR

  • Removed the margin-top: 0; style from the solution.css on the .title element
  • Updated desired-outcome.png, the screenshot in the README to reflect the above change (the screenshot shows the default margin-top for the "I'm a card" text)

Issue

Closes #545

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. 01-flex-center: Update self check
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If applicable, I have ensured that the TOP solution files match the Desired Outcome image

Copy link
Member

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

While we greatly appreciate your contribution, as a note for the future please don't work on open issues if you haven't been assigned to them 🙂

@wise-king-sullyman wise-king-sullyman merged commit 4bd42de into TheOdinProject:main Jun 11, 2024
TeamPlatinum1 pushed a commit to TeamPlatinum1/css-exercises that referenced this pull request Sep 3, 2024
02-margin-and-padding-2: Updated solution.css and desired-outcome.png to solve Issue#545
Oussama5379 added a commit to Oussama5379/css-exercises that referenced this pull request Feb 1, 2025
02-margin-and-padding-2: Updated solution.css and desired-outcome.png to solve Issue#545
CourtzDee pushed a commit to CourtzDee/css-exercises that referenced this pull request Apr 2, 2025
02-margin-and-padding-2: Updated solution.css and desired-outcome.png to solve Issue#545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block and Inline: <Element defaults not really being mentioned so far in the course>
2 participants