Specialize the container type for antichains #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiguru
force-pushed
the
timestamp_container
branch
from
b00a8f1 to
56b10fa
Compare
|
This PR has the deficit that it's not possible to create a This functionality is required by Differential. I don't think there's a good work-around other than splitting the |
Antichains are currently unconditionally heap-allocated. For totally ordered elements, an antichain will container zero or one elements, but not more. This would allow us to avoid the heap allocation and instead store the element inline. To enable this, we add an associated type to `Timestamp` that defines a container storing an antichain of the type. The container implements the functionality to let the current `Antichain` type function without change. The obvious downside of this change is that we now include a type bound `T: Timestamp` on the `Antichain` type, because the elements are based on `T`'s associated type, which infects a bunch of other places. Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru
force-pushed
the
timestamp_container
branch
from
56b10fa to
4ab758d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Antichains are currently unconditionally heap-allocated. For totally
ordered elements, an antichain will container zero or one elements, but not
more. This would allow us to avoid the heap allocation and instead store
the element inline.
To enable this, we add an associated type to
Timestampthat defines acontainer storing an antichain of the type. The container implements the
functionality to let the current
Antichaintype function without change.The obvious downside of this change is that we now include a type bound
T: Timestampon theAntichaintype, because the elements are based onT's associated type, which infects a bunch of other places.Signed-off-by: Moritz Hoffmann [email protected]