Specialize the container type for antichains #462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Antichains are currently unconditionally heap-allocated. For totally
ordered elements, an antichain will container zero or one elements, but not
more. This would allow us to avoid the heap allocation and instead store
the element inline.
To enable this, we add an associated type to
Timestamp
that defines acontainer storing an antichain of the type. The container implements the
functionality to let the current
Antichain
type function without change.The obvious downside of this change is that we now include a type bound
T: Timestamp
on theAntichain
type, because the elements are based onT
's associated type, which infects a bunch of other places.Signed-off-by: Moritz Hoffmann [email protected]