Skip to content

Conversation

abhijeetgangan
Copy link
Collaborator

@abhijeetgangan abhijeetgangan commented Apr 14, 2025

Summary

Closes #107

Checklist

Work-in-progress pull requests are encouraged, but please enable the draft status on your PR.

Before a pull request can be merged, the following items must be checked:

  • Doc strings have been added in the Google docstring format.
    Run ruff on your code.
  • Tests have been added for any new functionality or bug fixes.
  • All linting and tests pass.

Note that the CI system will run all the above checks. But it will be much more
efficient if you already fix most errors prior to submitting the PR. It is highly
recommended that you use the pre-commit hook provided in the repository. Simply run
pre-commit install and a check will be run prior to allowing commits.

@cla-bot cla-bot bot added the cla-signed Contributor license agreement signed label Apr 14, 2025
@abhijeetgangan abhijeetgangan marked this pull request as ready for review April 14, 2025 13:35
Copy link
Collaborator

@orionarcher orionarcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small suggestions, thanks @abhijeetgangan

@abhijeetgangan abhijeetgangan merged commit 5992aa7 into main Apr 14, 2025
86 checks passed
@abhijeetgangan abhijeetgangan deleted the fire_positions_only branch April 14, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unit_cell_fire requires stress for evaluation even when cell is fixed

2 participants