Skip to content

Conversation

curtischong
Copy link
Collaborator

@curtischong curtischong commented Apr 30, 2025

Summary

Checklist

Before a pull request can be merged, the following items must be checked:

  • Doc strings have been added in the Google docstring format.
    Run ruff on your code.
  • Tests have been added for any new functionality or bug fixes.
  • All linting and tests pass.

Copy link

cla-bot bot commented Apr 30, 2025

We require contributors to sign our Contributor License Agreement (CLA), and we don't have record of your signature. In order for us to review and merge your code, please sign the CLA.

@CompRhys
Copy link
Member

CompRhys commented May 1, 2025

ASE is only used for ASE specific IO and the same pattern is used for all IO to other package formats (https://github.com/Radical-AI/torch-sim/blob/main/torch_sim/io.py). This is also a common pattern used in many material science packages to not have IO to everything else under the sun as a core dependency.

Copy link

cla-bot bot commented May 1, 2025

We require contributors to sign our Contributor License Agreement (CLA), and we don't have record of your signature. In order for us to review and merge your code, please sign the CLA.

@CompRhys CompRhys force-pushed the make-ase-a-required-dependency branch from 5b7e7c7 to 5d071c6 Compare May 1, 2025 12:14
Copy link

cla-bot bot commented May 1, 2025

We require contributors to sign our Contributor License Agreement (CLA), and we don't have record of your signature. In order for us to review and merge your code, please sign the CLA.

@curtischong curtischong changed the title make ase a required dependency io Optional Dependencies in pyproject.toml May 1, 2025
@CompRhys
Copy link
Member

CompRhys commented May 1, 2025

@curtischong Can you sign the CLA with email associated to github and then can merge this?

@cla-bot cla-bot bot added the cla-signed Contributor license agreement signed label May 1, 2025
@CompRhys CompRhys merged commit 8da64d2 into main May 1, 2025
89 of 91 checks passed
@CompRhys CompRhys deleted the make-ase-a-required-dependency branch May 1, 2025 20:59
@janosh janosh added fix Bug fix pkg Packaging labels May 2, 2025
@janosh janosh changed the title io Optional Dependencies in pyproject.toml io optional dependencies in pyproject.toml May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor license agreement signed fix Bug fix pkg Packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants