This repository was archived by the owner on Jun 22, 2025. It is now read-only.
fix(image): ensure images opened in a new tab can be activated #2303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
eliandoran
approved these changes
Jun 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
In text notes, the first
Ctrl+Shift+Clickon an image correctly opens the image in a new tab and activates it.However, after switching back to the original tab, a second
Ctrl+Shift+Clickalso opens the image in a new tab, but fails to activate it.This issue occurs because the click event propagates to the following handler in
apps/client/src/widgets/containers/split_note_container.ts:As a result, after the image tab is activated, it is immediately switched back to the original tab, making it appear as though the image tab was not activated.