Added UTM dropdowns to Analytics Growth pages #25104
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| import React from 'react'; | ||
| import {TableFilterDropdownTab, TableFilterTab, TableFilterTabs} from '../table-filter-tabs/table-filter-tabs'; | ||
|
|
||
| export type GrowthCampaignType = '' | 'UTM sources' | 'UTM mediums' | 'UTM campaigns' | 'UTM contents' | 'UTM terms'; | ||
| export type GrowthTabType = 'sources' | 'campaigns'; | ||
|
|
||
| export const GROWTH_CAMPAIGN_TYPES = [ | ||
| 'UTM sources', | ||
| 'UTM mediums', | ||
| 'UTM campaigns', | ||
| 'UTM contents', | ||
| 'UTM terms' | ||
| ] as const satisfies readonly Exclude<GrowthCampaignType, ''>[]; | ||
|
|
||
| export const UTM_TYPE_MAP: Record<Exclude<GrowthCampaignType, ''>, string> = { | ||
| 'UTM sources': 'utm_source', | ||
| 'UTM mediums': 'utm_medium', | ||
| 'UTM campaigns': 'utm_campaign', | ||
| 'UTM contents': 'utm_content', | ||
| 'UTM terms': 'utm_term' | ||
| }; | ||
|
|
||
| export const getUtmType = (campaign: GrowthCampaignType): string => { | ||
| return campaign ? UTM_TYPE_MAP[campaign as Exclude<GrowthCampaignType, ''>] || '' : ''; | ||
| }; | ||
|
|
||
| export const GROWTH_CAMPAIGN_OPTIONS = GROWTH_CAMPAIGN_TYPES.map(type => ({ | ||
| value: type, | ||
| label: type | ||
| })); | ||
|
|
||
| interface UtmGrowthTabsProps { | ||
| className?: string; | ||
| selectedTab: GrowthTabType; | ||
| onTabChange: (tab: GrowthTabType) => void; | ||
| selectedCampaign: GrowthCampaignType; | ||
| onCampaignChange: (campaign: GrowthCampaignType) => void; | ||
| } | ||
|
|
||
| export const UtmGrowthTabs: React.FC<UtmGrowthTabsProps> = ({ | ||
| className, | ||
| selectedTab, | ||
| onTabChange, | ||
| selectedCampaign, | ||
| onCampaignChange | ||
| }) => { | ||
| const handleTabChange = (tab: string) => { | ||
| // Prevent switching to campaigns without selection | ||
| if (tab === 'campaigns' && !selectedCampaign) { | ||
| return; | ||
| } | ||
| onTabChange(tab as GrowthTabType); | ||
|
|
||
| // Clear campaign when switching away | ||
| if (tab !== 'campaigns') { | ||
| onCampaignChange(''); | ||
| } | ||
| }; | ||
|
|
||
| const handleCampaignChange = (campaign: string) => { | ||
| onCampaignChange(campaign as GrowthCampaignType); | ||
| onTabChange('campaigns'); | ||
| }; | ||
|
|
||
| return ( | ||
| <TableFilterTabs | ||
| className={className} | ||
| selectedTab={selectedTab} | ||
| onTabChange={handleTabChange} | ||
| > | ||
| <TableFilterTab value='sources'>Sources</TableFilterTab> | ||
| <TableFilterDropdownTab | ||
| options={GROWTH_CAMPAIGN_OPTIONS} | ||
| placeholder='Campaigns' | ||
| selectedOption={selectedCampaign} | ||
| value='campaigns' | ||
| onOptionChange={handleCampaignChange} | ||
| /> | ||
| </TableFilterTabs> | ||
| ); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review the CardHeader placement inside table structure.
The
CardHeadercomponent (lines 251-254) is being passed as children toSourcesTableand will be rendered inside a<th>element (see line 33 where{children}appears inTableHead). This creates semantically incorrect HTML with complex div structures nested inside table header cells.While the
headerStyle='card'andvariant='cardhead'suggest this might be intentional, consider:<th>elementsConsider refactoring to render the
CardHeaderoutside theSourcesTable, similar to how it's done whentopSources.length <= 0(lines 209-212). The table should only contain tabular data in its header, not complex component structures.Alternative structure:
<> {utmTrackingEnabled && mode === 'growth' && ( <>...</> )} + <CardHeader> + <CardTitle>{cardTitle}</CardTitle> + <CardDescription>{cardDescription}</CardDescription> + </CardHeader> <SourcesTable data={topSources} defaultSourceIconUrl={defaultSourceIconUrl} getPeriodText={getPeriodText} - headerStyle='card' mode={mode} range={range} - > - <CardHeader> - <CardTitle>{cardTitle}</CardTitle> - <CardDescription>{cardDescription}</CardDescription> - </CardHeader> - </SourcesTable> + /> </>🤖 Prompt for AI Agents