Skip to content

Add test for let x: Promise<object> #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2019
Merged

Add test for let x: Promise<object> #881

merged 1 commit into from
Jan 2, 2019

Conversation

NaridaL
Copy link
Contributor

@NaridaL NaridaL commented Oct 9, 2018

@NaridaL
Copy link
Contributor Author

NaridaL commented Oct 9, 2018

It passes on [email protected].

@aciccarello
Copy link
Collaborator

Fantastic, thanks for writing up a test and confirming! I'll close the issue and leave this PR open until we can update TypeScript.

@aciccarello aciccarello mentioned this pull request Oct 9, 2018
Closed
@aciccarello
Copy link
Collaborator

Looks like the upstream fix wasn't included in the TypeScript 3.1.3 release.

@aciccarello aciccarello mentioned this pull request Dec 19, 2018
Merged
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jan 2, 2019

Thanks for the PR! Merged now that the upstream fix is present.

@Gerrit0 Gerrit0 merged commit a4669a7 into TypeStrong:master Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NaridaL @aciccarello @Gerrit0