This repository was archived by the owner on Jan 3, 2025. It is now read-only.
Make cctor not fail if the domain contains even a single type that fa… #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iled to initialize. also, make it faster.
| { | ||
| foreach (System.Reflection.Assembly assembly in AppDomain.CurrentDomain.GetAssemblies()) | ||
| { | ||
| foreach (Type type in assembly.GetTypes()) |
There was a problem hiding this comment.
Seems like this could be a much less invasive change just by replacing the inner loop with a checked assembly.GetType(fullTypeNameConstructedFromTypenamespaceAndTypename)
There was a problem hiding this comment.
a bit more invasive, but also a bit more safe, as we actually wouldn't want to accidentally pick up a [ExtensionAttribute] from a user assembly. very small risk, but I figured I'd do that while I was at it.
Tak
added a commit
that referenced
this pull request
Jul 23, 2015
Make cctor not fail if the domain contains even a single type that fa…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iled to initialize.
also, make it faster.