Skip to content

Useless import should be removed #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
13Flo opened this issue Mar 2, 2019 · 6 comments
Closed

Useless import should be removed #1779

13Flo opened this issue Mar 2, 2019 · 6 comments
Assignees
@mantasp

Comments

@13Flo
Copy link

13Flo commented Mar 2, 2019

Just a heads up -- unused import System.Runtime.Remoting.Messaging; should be removed from BarracudaModelParamLoader.cs because it generates an error in Unity 2018.3.6
@mantasp mantasp self-assigned this Mar 13, 2019
@X-funbean
Copy link

It generates error CS0234 in Unity 2018.3.10f1, too

@mantasp
Copy link
Contributor

mantasp commented Mar 27, 2019

Hi, I can't reproduce this error on my machine. Are you seeing this error in Unity or in some external editor? Could you please attach screenshot?
Thanks!

@X-funbean
Copy link

@mantasp
image
and in VS2017 it says useless
image

@mantasp
Copy link
Contributor

mantasp commented Mar 27, 2019

Thank you! turns out it's related to API compatibility setting == ".NET Standard 2.0", which is not a default for ML Agents project.

vincentpierre pushed a commit that referenced this issue Mar 28, 2019
@mantasp @vincentpierre
Fixed compilation under Scripting API compatibility level ".NET Stand…
adfd705 
…ard 2.0" (#1869)

Fixing #1779
@mantasp
Copy link
Contributor

mantasp commented Mar 28, 2019

Fix landed to "develop" branch

@mantasp mantasp closed this as completed Mar 28, 2019
@lock
Copy link

lock bot commented Mar 27, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mantasp mantasp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@13Flo @mantasp @X-funbean