-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Improve Gym wrapper compatibility and add Dopamine documentation #1541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atari and other Gym environments use visual obs that are 0-255, rather than 0-1.
game_over is used by dopamine and other libraries to check for Atari completion.
Baselines also expects 0-255 rather than 0-1.
…l-agents into develop-dopaminegym
mmattar
suggested changes
Jan 5, 2019
Also clean up visual_banana plot
mmattar
reviewed
Jan 5, 2019
mmattar
reviewed
Jan 7, 2019
mmattar
approved these changes
Jan 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last minor comment: the figure boundary is only visible for half of the figure. Applies to both figures.
mantasp
added a commit
that referenced
this pull request
Jan 28, 2019
…agents into develop-barracuda * 'develop-barracuda' of github.com:Unity-Technologies/ml-agents: deleted dead meta file and added a note on the OpenGLCore Graphics API Barracuda : Updating the documentation (#1607) Remove env creation logic from TrainerController (#1562) Fix In editor Docker training (#1582) Only using multiprocess when --num-runs>1 (#1583) Replace AddVectorObs(float[]) and AddVectorObs(List<float>) with a more generic AddVectorObs(IEnumerable<float>) (#1540) fixed the windows ctrl-c bug (#1558) Improve Gym wrapper compatibility and add Dopamine documentation (#1541) Fix typo in documentation (#1516) Update curricula brain names for 0.6 Addressing #1537 Fix for divide-by-zero error with Discrete Actions (#1520) Documentation tweaks and updates (#1479)
mantasp
added a commit
that referenced
this pull request
Jan 29, 2019
* develop-barracuda: Backup and restore fixedDeltaTime and maximumDeltaTime on Academy init / shutdown Restore global gravity value when Academy gets destroyed deleted dead meta file and added a note on the OpenGLCore Graphics API Barracuda : Updating the documentation (#1607) Remove env creation logic from TrainerController (#1562) Fix In editor Docker training (#1582) Only using multiprocess when --num-runs>1 (#1583) Replace AddVectorObs(float[]) and AddVectorObs(List<float>) with a more generic AddVectorObs(IEnumerable<float>) (#1540) fixed the windows ctrl-c bug (#1558) Improve Gym wrapper compatibility and add Dopamine documentation (#1541) Fix typo in documentation (#1516) Update curricula brain names for 0.6 Addressing #1537 Fix for divide-by-zero error with Discrete Actions (#1520) Documentation tweaks and updates (#1479)
harperj
pushed a commit
that referenced
this pull request
Feb 20, 2019
* Add option to set gym visual observation to uint8 * Add option to flatten branched discrete actions * Add game_over variable to gym wrapper * Add guide on how to use Dopamine with the gym wrapper and comparisons with Baselines and PPO
LeSphax
pushed a commit
to LeSphax/ml-agents-1
that referenced
this pull request
May 3, 2020
…ty-Technologies#1541) * Add option to set gym visual observation to uint8 * Add option to flatten branched discrete actions * Add game_over variable to gym wrapper * Add guide on how to use Dopamine with the gym wrapper and comparisons with Baselines and PPO
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to Gym Wrapper
Changes to Documentation