Update Learning-Environment-Design-Agents.md #1659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tfix-0.6.0a Hotfix 0.6.0a to master
xiaomaogy
suggested changes
Feb 6, 2019
| AddVectorObs(speed.x); | ||
| AddVectorObs(speed.y); | ||
| AddVectorObs(speed.z); | ||
| ``` |
There was a problem hiding this comment.
Why are you removing this part?
There was a problem hiding this comment.
Because the following statements are no longer true:
You must explicitly convert Boolean values to a number.
For entities like positions and rotations, you [should] add their components to the feature list individually.
I can retain the examples, but I'd just be rewriting them to call AddVectorObs(isTrueOrFalse) and AddVectorObs(speed), which seemed unnecessary. The previous author apparently thought that an example for directly adding integers was unnecessary, so I followed the same custom for these types as well.
| @@ -128,24 +128,12 @@ properties to use a continuous vector observation: | |||
| * **Space Size** — The state size must match the length of your feature vector. | |||
|
|
|||
| The observation feature vector is a list of floating point numbers, which means | |||
| you must convert any other data types to a float or a list of floats. | |||
| you must convert any other data types to a float or a list of floats. | |||
| AddVectorObs((int)currentItem, NUM_ITEM_TYPES); | ||
| } | ||
| ``` | ||
|
|
xiaomaogy
approved these changes
Feb 6, 2019
LeSphax
pushed a commit
to LeSphax/ml-agents-1
that referenced
this pull request
May 3, 2020
* Update Learning-Environment-Design-Agents.md * Space typo * Word change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various documentation updates for the updated interface