Develop codacy test #1667
Develop codacy test #1667
Conversation
Hotfix 0.6.0a to master
|
@mmattar Since you setup the Codacy before, it would be better you could change these on your end. (Or we could change this when I get back. ) This PR is just a demo of what needs to be changed.
Vince and I looked at the code analysis of After this Code Patterns setup (Turning on Pylint, Remark Lint for markdown), this is the list of issues that are raised on this branch, which are much more reasonable. https://app.codacy.com/app/xiaomaogy/ml-agents/files?bid=11067808 |
ml-agents/setup.py
Outdated
| @@ -37,7 +37,9 @@ | |||
| 'docopt', | |||
| 'pyyaml', | |||
| 'protobuf>=3.6,<3.7', | |||
| 'grpcio>=1.11.0,<1.12.0'], | |||
| 'grpcio>=1.11.0,<1.12.0', | |||
| 'pytest-cov==2.6.1', | |||
There was a problem hiding this comment.
I kind of think the end user should not have to install those. Ideally, these last 2 requirements will be line 34 of .circleci/config.yml as pip install ...
README.md
Outdated
| @@ -4,6 +4,12 @@ | |||
|
|
|||
| # Unity ML-Agents Toolkit (Beta) | |||
|
|
|||
| [](https://www.codacy.com/app/xiaomaogy/ml-agents?utm_source=github.com&utm_medium=referral&utm_content=Unity-Technologies/ml-agents&utm_campaign=Badge_Grade) | |||
There was a problem hiding this comment.
Like @xiaomaogy said in his comment, we probably don't want this here. Is it possible to have this badge be either on a separate branch, a separate repo or even be only on slack ?
There was a problem hiding this comment.
Yes it is possible to have this badge on a separate branch (or a separate repo).
If we put this on for example develop branch, when we merge it we need to manually remove it, which is not desired.
If we put this on other branches, we would need to sync all of the code changes to both the develop branch and this other branch.
We could also put this on slack. It is just a link so we can just put it anywhere we want as long as we remember to check it.
Also codacy has this nice feature of analyzing every PR's code change, to track the code quality change according to its standard. (https://app.codacy.com/app/marwan/ml-agents/pullRequest?prid=3010293)
|
@awjuliani What do you think of the badge? https://github.com/Unity-Technologies/ml-agents/blob/de7388a16405130dff93d377cbeda8c1b89684cf/README.md |
xiaomaogy
force-pushed
the
develop-codacy-test
branch
from
476f013 to
925b044
Compare
…der, so that it covers gym_unity’s pytest also
* fixed the test break on pytest > 4.0, added the pytest cov * added the pytest-cov package * added the logic to upload coverage.yml report to codacy * remove the warning message in during the pytest * added the codacy badge to show what it looks like * added a space * removed the space * removed the duplicate pytest * removed the extra spaces * added the test coverage badge * point the badge to the test branch * changed * moved the python test coverage to circleci * removed the badge * added the badge * fixed the link * Added the gym_unity test to the circleci * Fixed the gym_unity installation * Changed the test-reports from the ml-agents subfolder to the root folder, so that it covers gym_unity’s pytest also
No description provided.