Release v0.7 disable gRPC on non supported platforms #1743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantasp
reviewed
Feb 21, 2019
| @@ -2,6 +2,9 @@ | |||
| // Generated by the protocol buffer compiler. DO NOT EDIT! | |||
| // source: mlagents/envs/communicator_objects/unity_to_external.proto | |||
| // </auto-generated> | |||
|
|
|||
| # if UNITY_EDITOR || UNITY_STANDALONE_WINDOWSWINDOWS || UNITY_STANDALONE_OSX || UNITY_STANDALONE_LINUX | |||
There was a problem hiding this comment.
UNITY_STANDALONE_WINDOWSWINDOWS looks like a typo
awjuliani
reviewed
Feb 21, 2019
protobuf-definitions/README.md
Outdated
| @@ -26,3 +26,14 @@ On Windows & Linux: [See here](https://github.com/google/protobuf/blob/master/sr | |||
| 1. Install pre-requisites. | |||
| 2. Un-comment line 4 in `make.bat`, and set to correct Grpc.Tools sub-directory. | |||
| 3. Run `make.bat` | |||
| 4. In the generated `UnityToExternalGrpc.cs` file in the `CommunicatorObjects` folder, you will need to add on top of the file the line | |||
There was a problem hiding this comment.
Say where CommunicatorObjects folder is (i.e. in UnitySDK).
Also change "to add on top of the file the line"
to
"to add the following to the beginning of the file"
awjuliani
reviewed
Feb 21, 2019
protobuf-definitions/README.md
Outdated
| ```csharp | ||
| # if UNITY_EDITOR || UNITY_STANDALONE_WIN || UNITY_STANDALONE_OSX || UNITY_STANDALONE_LINUX | ||
| ``` | ||
| and at the bottom of the file the line |
There was a problem hiding this comment.
"and the following line to the end"
awjuliani
reviewed
Feb 21, 2019
protobuf-definitions/README.md
Outdated
| ```csharp | ||
| #endif | ||
| ``` | ||
| This is to make sure the Grpc library is not used on platforms that do not support training. |
There was a problem hiding this comment.
Explain why this is needed.
There was a problem hiding this comment.
You mean more than the current explanation ? What is missing in it ? I say It is to make sure the Grpc library is not used on platforms that do not support training
LeSphax
pushed a commit
to LeSphax/ml-agents-1
that referenced
this pull request
May 3, 2020
…ies#1743) * Fix for GRPC, need documentation * Edits * typo * Fixes * Missing typo * Modified the documentation * Updated the documentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be a quick fix for disabling training on unsupported platforms.
Might still need to document that if the user wants to recompile the protobuf objects, they will need to edit the generated files.
I tested it on UWP