Skip to content

Develop windows install instructions update #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 26, 2019
Merged

Develop windows install instructions update #1760

merged 4 commits into from
Feb 26, 2019

Conversation

dmalpica
Copy link
Contributor

As discussed here: #1706

Fixed typos on Installation-Windows.md that made instructions unclear. Added warning about overwriting drivers.
Copy link
Contributor

@vincentpierre vincentpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure the Warning is necessary given that it is not a ML-Agents issue. Maybe adding a link to a CUDA documentation page that discusses this issue would be good if the Warning stays.
I am not a fan of having

python

<python code>

Because the two are in different languages. I would prefer : Open Python in the Prompt by calling

python

and then type the following commands

<python code>

to test if everything was installed properly

@dmalpica
Copy link
Contributor Author

@vincentpierre Thanks for the feedback. I looked around but couldn't find a solid source documenting the issues I experienced, so I took out the warning.

That said, I found a more recent post that might be helpful:
https://www.pugetsystems.com/labs/hpc/The-Best-Way-to-Install-TensorFlow-with-GPU-Support-on-Windows-10-Without-Installing-CUDA-1187/

I addressed the other issue differentiating the anaconda prompt command from the python commands.

I am not sure the Warning is necessary given that it is not a ML-Agents issue. Maybe adding a link to a CUDA documentation page that discusses this issue would be good if the Warning stays.
I am not a fan of having

python

<python code>

Because the two are in different languages. I would prefer : Open Python in the Prompt by calling

python

and then type the following commands

<python code>

to test if everything was installed properly

@vincentpierre vincentpierre merged commit 470a9d2 into Unity-Technologies:develop Feb 26, 2019
LeSphax pushed a commit to LeSphax/ml-agents-1 that referenced this pull request May 3, 2020
* As discussed here: Unity-Technologies#1706
Fixed typos on Installation-Windows.md that made instructions unclear. Added warning about overwriting drivers.

* edits

* edits, formatting

* Incorporated feedback from @vincentpierre
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants