Refactor RayPerception and add RayPerception2D #1793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentpierre
suggested changes
Mar 12, 2019
| @@ -28,7 +28,7 @@ public class BananaAgent : Agent | |||
| public Material frozenMaterial; | |||
| public GameObject myLaser; | |||
| public bool contribute; | |||
| private RayPerception rayPer; | |||
| private RayPerception3D rayPer; | |||
There was a problem hiding this comment.
This is going to break people's existing code
There was a problem hiding this comment.
Every major release involves breaking changes.
| return degree * Mathf.PI / 180f; | ||
| } | ||
| } | ||
| public class RayPerception : MonoBehaviour { |
There was a problem hiding this comment.
Is this supposed to be abstract ? Can this be made into an interface ?
There was a problem hiding this comment.
Yes. It should be abstract. It is not an interface because it includes static helper methods, and a declarations for variables.
| /// <param name="rayDistance">Radius of rays</param> | ||
| /// <param name="rayAngles">Angles of rays (starting from (1,0) on unit circle).</param> | ||
| /// <param name="detectableObjects">List of tags which correspond to object types agent can see</param> | ||
| public List<float> Perceive(float rayDistance, |
There was a problem hiding this comment.
Can this have a unit test ?
| /// <param name="detectableObjects">List of tags which correspond to object types agent can see</param> | ||
| /// <param name="startOffset">Starting height offset of ray from center of agent.</param> | ||
| /// <param name="endOffset">Ending height offset of ray from center of agent.</param> | ||
| public override List<float> Perceive(float rayDistance, |
There was a problem hiding this comment.
Can this have a unit-test too ?
vincentpierre
approved these changes
Mar 13, 2019
LeSphax
pushed a commit
to LeSphax/ml-agents-1
that referenced
this pull request
May 3, 2020
* Fix typos * Use abstract class for rayperception * Created RayPerception2D. (Unity-Technologies#1721) * Incorporate RayPerception2D * Fix typo * Make abstract class * Add tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.