Soccer Twos - Fixes missing tag change, plus code cleanup #1813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotfix 0.6.0a to master
Release v0.7 into master
vincentpierre
previously approved these changes
Mar 12, 2019
| { | ||
| detectableObjects = new string[] { "ball", "redGoal", "blueGoal", | ||
| detectableObjects = new[] { "ball", "redGoal", "blueGoal", |
There was a problem hiding this comment.
Why did you change that ? It makes it less explicit.
There was a problem hiding this comment.
The code is more concise. The extra string is redundant, because the contents are clearly already strings.
awjuliani
changed the title
|
I build soccer based on this branch, but the goalkeeper went out of the penalty area and acted more like a striker. |
|
Hi @xffxff Thanks for pointing out this bug. I've just added a commit which will address this. |
LeSphax
pushed a commit
to LeSphax/ml-agents-1
that referenced
this pull request
May 3, 2020
…nologies#1813) * Fixes missing tag change, plus code cleanup * Fix bug in agent position setting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(We probably want to merge this into a v0.7.0a hotfix, or potentially roll into v0.8.