Black formatting #1934
Merged
Black formatting #1934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harperj
suggested changes
Apr 15, 2019
There was a problem hiding this comment.
A few things I'd want to see before merging this:
- a script to run the exact command you ran to format the codebase
- addition of checking that
blackhas been run / passes on all PRs added to the circleCI config - a descriptive commit message
IMO the changes from the formatter look good, consistency is nice.
awjuliani
reviewed
Apr 15, 2019
|
Looks good, my only worry is that we don't have any explanation that external contributors need to run Could be part of https://github.com/Unity-Technologies/ml-agents/blob/master/CONTRIBUTING.md |
eshvk
force-pushed
the
develop-black
branch
2 times, most recently
from
488fd6f to
f6c9883
Compare
Features: - Reformat code via black. - Adding circleci configurations. - Add contribution guidelines. Steps to reproduce: - `pip install black` - `black <source code directory>`
|
@harperj fixed PTAL |
harperj
approved these changes
Apr 17, 2019
|
@harperj Can you explain this a little bit more? I added a line in |
|
Sorry @eshvk -- I must have missed that among all of the changes. PR looks good to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.