Skip to content

A couple fixes for recording demonstrations #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 3, 2019
Merged

A couple fixes for recording demonstrations #1999

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5bd52ab
Crop demonstration name to avoid overflow
Apr 30, 2019
e080503
Fix last action recorded is always 0
Apr 30, 2019
d09d209
Fixed issue where extra action taken after Done()
Apr 30, 2019
35ff235
Remove whitespace
Apr 30, 2019
bfc968a
Append comment
Apr 30, 2019
fbfec7e
Make max length a const and add comments
Apr 30, 2019
81bd12d
Fix comment and test for DemonstrationRecorder
Apr 30, 2019
c7a0166
Adjust comment
Apr 30, 2019
abdb0cb
Revert "Fixed issue where extra action taken after Done()"
May 1, 2019
8f23448
More elegant fix to 0 action recording
May 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed issue where extra action taken after Done()
  • Loading branch information
Ervin Teng committed Apr 30, 2019
commit d09d209ae28bf85272deeeac70e77ec8385fe4ee
4 changes: 3 additions & 1 deletion UnitySDK/Assets/ML-Agents/Scripts/Agent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,7 @@ void SendInfoToBrain()
{
info.storedVectorActions = action.vectorActions;
}

info.storedTextActions = action.textActions;
info.vectorObservation.Clear();
actionMasker.ResetMask();
Expand Down Expand Up @@ -1021,6 +1021,8 @@ void ResetIfDone()
// as it is done
_AgentReset();
hasAlreadyReset = true;
requestDecision = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we make sure this does not break stuff ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any of our environments (aside from Snoopy Pop, where this does work) use On Demand Decisions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bouncer uses ODD

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Training Bouncer, seems to work (1.0 reward after 50k steps and climbing)

requestAction = false;
}
}
else if (requestDecision)
Expand Down