Skip to content

Update Learning-Environment-Executable.md #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2019
Merged

Update Learning-Environment-Executable.md #2037

merged 2 commits into from
May 15, 2019

Conversation

shihzy
Copy link
Contributor

@shihzy shihzy commented May 13, 2019

fixed issue when creating a build folder in the assets folder. Refering to #2033

fixed issue when creating a build folder in the assets folder.  Refering to #2033
@shihzy shihzy requested a review from xiaomaogy May 15, 2019 15:09
that folder to build. In the following steps you will refer to this
subfolder's name as `env_name`.
subfolder's name as `env_name`. You cannot create builds in the Assets folder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "cannot" to "shouldn't"? You can but you shouldn't.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you actually cannot - it will throw an error

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok, then nvm.

@xiaomaogy
Copy link
Contributor

Looks good to me.

@shihzy shihzy merged commit 060d275 into develop May 15, 2019
@shihzy shihzy deleted the develop-doc-fix branch May 15, 2019 18:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants