Skip to content

Update Basic-Guide.md #2076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2019
Merged

Update Basic-Guide.md #2076

merged 2 commits into from
May 29, 2019

Conversation

laurentopia
Copy link
Contributor

added missing instruction at the end

eshvk and others added 2 commits April 15, 2019 13:50
Fix custom protobuf link in README
added missing instruction at the end
@shihzy shihzy self-requested a review May 28, 2019 20:37
@shihzy
Copy link
Contributor

shihzy commented May 28, 2019

@laurentopia - can you rebase to develop instead? Thanks!

@laurentopia
Copy link
Contributor Author

@unityjeffrey I don't know what that means

Copy link
Contributor

@shihzy shihzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approved - please switch branch to Develop

@shihzy
Copy link
Contributor

shihzy commented May 28, 2019

sorry - i wrote that too fast. meant to ask if you can change your branch to develop instead.

@laurentopia
Copy link
Contributor Author

I'm not familiar with gh, I looked all over the settings for that fork and couldn't find such switch.

@vincentpierre vincentpierre changed the base branch from master to develop May 29, 2019 20:21
@shihzy shihzy merged commit c860bcb into Unity-Technologies:develop May 29, 2019
@laurentopia laurentopia deleted the patch-1 branch May 30, 2019 06:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants