Skip to content

use yaml.safe_load instead of yaml.load #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2019
Merged

use yaml.safe_load instead of yaml.load #2124

merged 2 commits into from
Jun 12, 2019

Conversation

chriselion
Copy link
Contributor

This gets rid of these warnings

/.../ml-agents/ml-agents/mlagents/trainers/learn.py:157: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
trainer_config = yaml.load(data_file)

when running mlagents-learn. It's also just a generally good idea; see the link for more info.

@chriselion
Copy link
Contributor Author

Tests failing until #2125 is merged in

@chriselion chriselion requested a review from xiaomaogy June 12, 2019 00:55
@chriselion chriselion mentioned this pull request Jun 12, 2019
Closed
@chriselion chriselion merged commit 9c354a6 into develop Jun 12, 2019
@chriselion chriselion mentioned this pull request Jun 12, 2019
Merged
@chriselion chriselion deleted the develop-yaml-safe_load branch July 11, 2019 22:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xiaomaogy xiaomaogy xiaomaogy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriselion @xiaomaogy