Skip to content

Barracuda - remove unused private variable #2128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2019
Merged

Barracuda - remove unused private variable #2128

merged 1 commit into from
Jun 13, 2019

Conversation

chriselion
Copy link
Contributor

Follow up from #2049

Fixes a warning:

Assets/ML-Agents/Scripts/InferenceBrain/GeneratorImpl.cs(123,21): warning CS0414: The private field `MLAgents.InferenceBrain.BarracudaRecurrentInputGenerator.memoriesCount' is assigned but its value is never used

@mantasp Can you confirm this is correct? Not sure if it's supposed to be used instead of e.g. memory.Count in Generate()

@chriselion chriselion requested a review from mantasp June 12, 2019 20:57
@chriselion chriselion mentioned this pull request Jun 12, 2019
Merged
@shihzy shihzy requested a review from vincentpierre June 13, 2019 15:35
mantasp
mantasp approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@mantasp mantasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@chriselion chriselion merged commit 04168ae into develop Jun 13, 2019
@chriselion chriselion deleted the develop-fix-barracuda-warning branch July 11, 2019 22:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mantasp mantasp mantasp approved these changes

@vincentpierre vincentpierre Awaiting requested review from vincentpierre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriselion @mantasp