Fix Protobuf Install Instructions #2138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rsfutch77
commented
Jun 16, 2019
rsfutch77
commented
- There were some steps missing for the mlagents re-install
- Fixed make_for_win.bat which was missing some variables and other small errors
- Other clarifications for how to re-build all the automatically generated files
- Fix slash direction for windows in COMPILER definition - Fix missing COMPILER variables when calling protoc - Fix call to "python" instead of "python3"
- Note to use the windows batch file on windows
- Put rem back in make_fo_win.bat
- Notes for where to enter commands to start with - Select a particular version of grpcio-tools - Note how to get nuget if needed - Directory independent nuget install - Remove instruction to download protoc since it comes with grpc.tools - Add instructions for windows in ##Running and directories for clarification
- Update protobuf folder ignores
- Revert version to what is currently in develop branch to clarify what changed.
- Ignore grpc installation on any platform
- make_for_win_.bat now has the same comment as make.bat - The instructions for editing those files will both use line 7 now.
- Add required version for grpc tools. Newer versions cause UnityToExternalGrpc.cs to fail to compile inside Unity due to a new function in the file
- Include grpc required versions - Clarify which steps are install and which are run every time
- Fix re-install directions to include -e modifer - Move re-install directions from creating-custom... to protobuf readme - Add how to see confirmation that install worked
|
hi @rsfutch77 - we into master a couple of days ago and updated the develop branch. could you rebase / resolve the conflicts and we can review? thank you again for your contributions. |
xiaomaogy
approved these changes
Jun 26, 2019
xiaomaogy
suggested changes
Jun 26, 2019
There was a problem hiding this comment.
Hi @rsfutch77, once you sign the CLA and resolved the conflict. I'll approve it and you can merge. The PR looks good to me.
|
Resolved and CLA signed! |
xiaomaogy
approved these changes
Jun 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.