Use pre-commit for CI tests, add black hook #2163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
changed the title
chriselion
commented
Jun 21, 2019
.circleci/config.yml
Outdated
| black --check ml-agents | ||
| black --check ml-agents-envs | ||
| black --check gym-unity | ||
| git ls-files ml-agents | xargs pre-commit run --show-diff-on-failure --files |
There was a problem hiding this comment.
I don't love this because it makes it harder to run the same checks on CI and locally. After mypy checks are running (in another PR) I'll revisit this.
There was a problem hiding this comment.
Figured out how to get mypy working with a single invocation, so can do this in one call now.
chriselion
commented
Jun 21, 2019
| @@ -24,7 +24,7 @@ jobs: | |||
| pip install --upgrade setuptools | |||
| cd ml-agents-envs && pip install -e . | |||
| cd ../ml-agents && pip install -e . | |||
| pip install black pytest-cov==2.6.1 codacy-coverage==1.3.11 | |||
| pip install pre-commit pytest-cov==2.6.1 codacy-coverage==1.3.11 | |||
There was a problem hiding this comment.
pre-commit will install all the corresponding hooks that it needs, so we don't need to install black directly anymore.
xiaomaogy
approved these changes
Jun 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up pre-commit (https://pre-commit.com/hooks.html) with a single hook to run
black. This is a no-op for now, but we can add other checks like mypy soon.You can see the output from a failed CI run here: https://circleci.com/gh/Unity-Technologies/ml-agents/873?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link It's slightly nicer (IMHO) since it shows the diff of applying the linter, so you have a better idea of where the failure is.