Updated minor typos (sh for console) #2172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix custom protobuf link in README
Markdown for Github shows better with that change
|
hi @quevedin - thank you for your contribution. can you change the branch from master to develop? We don't allow direct contributions to master in this way. After, we will review / approve. |
|
Sure!
…On Wed, Jun 26, 2019 at 7:01 PM Jeffrey Shih ***@***.***> wrote:
hi @quevedin <https://github.com/quevedin> - thank you for your
contribution. can you change the branch from master to develop? We don't
allow direct contributions to master in this way. After, we will review /
approve.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2172?email_source=notifications&email_token=AAMFT6YYKYEF5ELHF3T57DLP4OOFRA5CNFSM4H2ZVZM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYUFSDY#issuecomment-505960719>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMFT67NGGWOZAQSIYN7ILTP4OOFRANCNFSM4H2ZVZMQ>
.
|
|
@unityjeffrey , I think I switched the branches correctly, right? |
|
yep @quevedin! |
|
cc: @xiaomaogy |
xiaomaogy
approved these changes
Jun 26, 2019
|
Looks good to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markdown for Github shows better with that change