-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Enable mypy in precommit checks #2177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
3342f8a
WIP precommit on top level
8284924
update CI
8e48831
circleci fixes
f06cba6
intentionally fail black
30298e0
use --show-diff-on-failure in CI
a84c05d
fix command order
f31aa33
rebreak a file
9ae5869
apply black
fd4f3bb
WIP enable mypy
b49a455
run mypy on each package
c3814bc
fix trainer_metrics mypy errors
e904f5d
more mypy errors
d3a1bc4
more mypy
6a4d282
Fix some partially typed functions
094893e
types for take_action_outputs
0e79001
fix formatting
1468c43
Merge remote-tracking branch 'origin/develop' into develop-precommit-…
a32de87
cleanup
ad73974
generate stubs for proto objects
83269d2
fix ml-agents-env mypy errors
ff8565d
disallow-incomplete-defs for gym-unity
3e90e0e
Add CI notes to CONTRIBUTING.md
chriselion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Add CI notes to CONTRIBUTING.md
- Loading branch information
commit 3e90e0e7662db55beeea85eb7d94b75fe244b36a
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is still a style guide, we just enforce our style through CI, so maybe still keep this as Style Guide?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a "Code Style" section below. I wanted to give a little more explanation about how the checks (black, mypy, and anything else we add later) were run. I can change this back and move it to another doc if you think it was better before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I think everything is fine here. I don't have a strong opinion on this.