Skip to content

Develop rayperception docs #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gregnz
Copy link
Contributor

@gregnz gregnz commented Jun 26, 2019

Adding docs to the RayPerception classes to clarify the construction of the sublists.

…point to clarify is the behaviour of returning a '1' on a **no hit**.
@CLAassistant
Copy link

CLAassistant commented Jun 26, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ chriselion
✅ gregnz
❌ xiaomaogy
You have signed the CLA already but the status is still pending? Let us recheck it.

@gregnz gregnz closed this Jun 26, 2019
@gregnz gregnz reopened this Jun 26, 2019
@shihzy
Copy link
Contributor

shihzy commented Jun 26, 2019

hi @gregnz - can you change the branch to develop instead of master? we do not allow direct commits to master this way. after, we can take a look and approve.

@gregnz gregnz changed the base branch from master to develop June 26, 2019 18:30
@gregnz
Copy link
Contributor Author

gregnz commented Jun 26, 2019

Thanks @unityjeffrey thats what I was trying to do :) should be good now.

@shihzy shihzy requested a review from awjuliani June 26, 2019 18:36
@shihzy
Copy link
Contributor

shihzy commented Jun 26, 2019

cc @awjuliani

Copy link
Contributor

@awjuliani awjuliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@xiaomaogy xiaomaogy merged commit e8018e8 into Unity-Technologies:develop Jun 26, 2019
@gregnz gregnz deleted the develop-rayperception-docs branch June 26, 2019 19:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants