Get timers from subprocess #2268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 26 commits
June 24, 2019 15:03
chriselion
commented
Jul 16, 2019
added 2 commits
July 17, 2019 15:22
chriselion
commented
Jul 17, 2019
harperj
reviewed
Jul 22, 2019
xiaomaogy
reviewed
Jul 23, 2019
| @@ -625,6 +627,7 @@ def _get_state(self, output: UnityRLOutput) -> Tuple[AllBrainInfo, bool]: | |||
| ) | |||
| return _data, global_done | |||
|
|
|||
| @timed | |||
| def _generate_step_input( | |||
There was a problem hiding this comment.
What is the purpose of timing this in addition to timing the env.step time here? I thought we intend to benchmark the communication time, which is the self.communicator.exchange function that calls this function.
There was a problem hiding this comment.
I put it there because that's where the protobuf serialization occurs. I'll put one on RpcCommunicator.communicate too.
|
Aside from my only comment, all seems reasonable to me. |
xiaomaogy
approved these changes
Jul 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the previous timer code to return the timer from the subprocess workers, and merge them into the timer tree.
Deciding to represent this is the hardest part. Instead of trying to track real/user time, I went with a simpler approach of flagging the nodes that are run in parallel; this is set when merging the trees.