Skip to content

Improve test_simple.py and check discrete actions #2345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 26, 2019

Conversation

chriselion
Copy link
Contributor

  • Use pytest.mark.parametrize to run multiple variants of the same basic test
  • Pick a random goal each "run" and pass that as an observation (instead of always going to +1)
  • Add a variant that covers discrete actions

@chriselion chriselion requested review from ervteng and xiaomaogy July 26, 2019 18:54
@ervteng
Copy link
Contributor

ervteng commented Jul 26, 2019

I think we should move the actual running of the test to the test_ppo.py file - what do you think?

@chriselion
Copy link
Contributor Author

Right now it's only testing PPO, but I think it's general enough to test other combinations of settings (memory, visual obs) and other trainers (SAC).

@xiaomaogy
Copy link
Contributor

I guess it is testing the rl aspect of the environment, so either rename it something like test_simple_rl or move it to test_ppo? The PR looks good to me, it is ok to merge.

@chriselion
Copy link
Contributor Author

Sounds good, I renamed to test_simple_rl.py and moved it to the main trainers/tests directory.

@chriselion chriselion merged commit c18f55c into develop Jul 26, 2019
@chriselion chriselion deleted the develop-test-discrete-action branch September 12, 2019 22:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants