unit test - don't use global random generator #2521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentpierre
approved these changes
Sep 9, 2019
|
For background, we set the tf and np seeds here ml-agents/ml-agents/mlagents/trainers/trainer_controller.py Lines 66 to 67 in 5ada924 but not python's global random seed. The only other place this appears to be used is |
vincentpierre
deleted the
develop-unit-test---don't-use-global-random-generator
branch
surfnerd
pushed a commit
that referenced
this pull request
Sep 12, 2019
* unit test - don't use global random generator * Update test_simple_rl.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(hopefully) make this test more deterministic. It's creating its own
random.Randominstance but not using it.